Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant \.id in SwiftUI.ForEach #555

Merged
merged 3 commits into from
Aug 17, 2024
Merged

Remove redundant \.id in SwiftUI.ForEach #555

merged 3 commits into from
Aug 17, 2024

Conversation

yimajo
Copy link
Contributor

@yimajo yimajo commented Aug 17, 2024

Issue

  • noting

Overview (Required)

  • When using SwiftUI.ForEach with items conforming to Identifiable, specifying \.id as an argument is redundant and can be omitted.

Links

Screenshot (Optional if screenshot test is present or unrelated to UI)

Before After

Movie (Optional)

Before After

MrSmart00
MrSmart00 approved these changes Aug 17, 2024
View reviewed changes
Copy link
Contributor

@MrSmart00 MrSmart00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your commit!
LGTM!

@MrSmart00 MrSmart00 merged commit 441a53c into DroidKaigi:main Aug 17, 2024
4 checks passed
@yimajo yimajo deleted the remove_redundant_key branch August 17, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrSmart00 MrSmart00 MrSmart00 approved these changes

Assignees
No one assigned
Labels
type:iOS 🍎
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yimajo @MrSmart00